conditionally add markup. Closes #398#403
Merged
angelleye merged 1 commit intoApr 30, 2019
Merged
Conversation
Collaborator
|
Hey, sorry, not sure how I missed these pull requests. Just now realizing it. It seems you have two different pull requests for the same issue, though. Should we close the previous and focus on this one? We'll be happy to get this merged. Just want to clarify. Thanks! |
Contributor
Author
|
The two PRs kind of look the same to me and I can no longer recall why I made the second one. But, I'm gonna trust my past self and say this is the better one. :) Would be great if you could get it merged in. |
Collaborator
|
Sounds good, thanks! We'll take a look at get it included in our next update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying this one more time.