Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution #35

Closed
maxrice opened this issue Apr 1, 2014 · 10 comments

Comments

Projects
None yet
2 participants
@maxrice
Copy link

commented Apr 1, 2014

This is a pretty cool implementation of all the various PayPal options into a single plugin, kudos :) However, based on a cursory review of the PayPal Express code, it appears you're using large portions of the copyrighted code from the official WooCommerce PayPal Express plugin. As all the official extensions are GPL-licensed, this is totally fine but you must add attribution back to the original author in your source.

@angelleye

This comment has been minimized.

Copy link
Owner

commented Apr 1, 2014

Yeah I started with their's and I was going to be content just buying their stuff and using it, however, I discovered lots of issues with their original extension that I was working with, so that's why I wound up turning it into my own stand-alone version.

I've stripped out all of their actual PayPal API stuff and replaced it with my own class library for PayPal. I've added quite a few improvements and plan on really turning this thing into an all-in-one solution for PayPal in WooCommerce. I've got version 1.1 nearly done and a plan for 1.2 already, too, which you can see in my issues list here.

Anyway, I never stripped any of their comments or tried to hide their stuff in any way, and I absolutely give them credit for what they've done with WooCommerce and their extensions. I'll go ahead and add an official thank you / attribution into my license info. They definitely deserve it!

@angelleye angelleye added this to the Version 1.1 milestone Apr 1, 2014

@angelleye

This comment has been minimized.

Copy link
Owner

commented Apr 2, 2014

And by "they", I apparently mean "you". :) Looks like you've contributed quite a bit to WooCommerce. Much appreciated!

@maxrice

This comment has been minimized.

Copy link
Author

commented Apr 2, 2014

Very welcome :) Yep, we have the official PayPal Express plugin which is long-overdue for a rewrite, coming in the next few weeks! I saw you kept all the comments and what not, and it's totally cool to fork the code into your own version, it's just a best practice to keep the attribution to the original author so it meets the GPL license requirements.

@angelleye

This comment has been minimized.

Copy link
Owner

commented Apr 2, 2014

This work?

PayPal for WooCommerce is a derivative work of the code from WooThemes, which is licensed with GPLv3. This code is also licensed under the terms of the GNU Public License, version 3.

@angelleye angelleye closed this Apr 2, 2014

@angelleye angelleye reopened this Apr 2, 2014

@angelleye angelleye closed this Apr 2, 2014

@maxrice

This comment has been minimized.

Copy link
Author

commented Apr 2, 2014

I'd say WooThemes / SkyVerge

@angelleye

This comment has been minimized.

Copy link
Owner

commented Apr 2, 2014

Ok, will do.

@angelleye angelleye reopened this Apr 3, 2014

@angelleye angelleye closed this Apr 3, 2014

@maxrice

This comment has been minimized.

Copy link
Author

commented Apr 3, 2014

thanks :)

@angelleye

This comment has been minimized.

Copy link
Owner

commented Nov 13, 2014

Hey maxrice, can you answer a quick question for me please? How do you guys do this?

image

I thought it was h andled through the "Update Notice" in my readme.txt file for my plugin, but that's only showing up for me in the Dashboard -> Updates section.

Any tip you can give me on that would be greatly appreciated. Thanks!

@maxrice

This comment has been minimized.

Copy link
Author

commented Nov 14, 2014

@angelleye honestly I'm not sure since that's a WooCommerce core thing. My guess is you'll find how they're doing it in the source :)

@angelleye

This comment has been minimized.

Copy link
Owner

commented Nov 14, 2014

I guess I wasn't aware you could control that from the source of the plugin. I thought that was all controlled from the readme.txt file. I'll look into that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.