New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments Pro American Express Adjustment #420

Closed
angelleye opened this Issue Feb 16, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@angelleye
Owner

angelleye commented Feb 16, 2016

I've been getting reports lately from users trying to accept Amex with currency codes other than USD. Those are getting rejected with invalid currency code errors. Apparently Amex only supports USD.

We need to verify that USD is the only one it supports (maybe it supports a few others, too..??) and then make sure the Amex option doesn't show up if the currency in WooCommerce is set to an unsupported Amex value.

@angelleye angelleye added the cleanup label Feb 16, 2016

@angelleye angelleye added this to the 1.2 milestone Feb 16, 2016

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Feb 26, 2016

Collaborator

You are talking about credit card drop-down right? Here I am little bit confused, Can you please explain more details?

Collaborator

kcppdevelopers commented Feb 26, 2016

You are talking about credit card drop-down right? Here I am little bit confused, Can you please explain more details?

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Feb 26, 2016

Owner

Yes, it would be in the drop down box that allows people to select their card type on the checkout page. If the currency code is not supported we need to hide Amex from the options in that drop down.

Owner

angelleye commented Feb 26, 2016

Yes, it would be in the drop down box that allows people to select their card type on the checkout page. If the currency code is not supported we need to hide Amex from the options in that drop down.

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Feb 27, 2016

Collaborator

as you know we already remove credit card drop down box and currently we are used woo default credit card interface. so we need to add it again?

Collaborator

kcppdevelopers commented Feb 27, 2016

as you know we already remove credit card drop down box and currently we are used woo default credit card interface. so we need to add it again?

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Mar 10, 2016

Owner

Ah, right, I forgot the new method does not have a drop down for the card type.

As such, we must have some logic that is setting the card type based on the credit card number, right?

Can we add some validation so that if the card type ends up being Amex but the currency is not USD we return a validation error?

Owner

angelleye commented Mar 10, 2016

Ah, right, I forgot the new method does not have a drop down for the card type.

As such, we must have some logic that is setting the card type based on the credit card number, right?

Can we add some validation so that if the card type ends up being Amex but the currency is not USD we return a validation error?

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Mar 12, 2016

Owner

I'm a little confused here. It looks like you're only throwing the validation error if the currency is CAD..??

CAD would actually be compatible according to this table: https://developer.paypal.com/docs/classic/api/currency_codes/#creditcard

So we should actually check if the currency code is not one of the compatible values from that table, and show the validation error if it's not in the list. So basically, these should be allowed: AUD, CAD, EUR, GBP, JPY, USD

Any other currency code, if Amex is the card type, should throw the validation error.

Owner

angelleye commented Mar 12, 2016

I'm a little confused here. It looks like you're only throwing the validation error if the currency is CAD..??

CAD would actually be compatible according to this table: https://developer.paypal.com/docs/classic/api/currency_codes/#creditcard

So we should actually check if the currency code is not one of the compatible values from that table, and show the validation error if it's not in the list. So basically, these should be allowed: AUD, CAD, EUR, GBP, JPY, USD

Any other currency code, if Amex is the card type, should throw the validation error.

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Mar 12, 2016

Owner

Also, I think we need to do the same thing to PayFlow.

Owner

angelleye commented Mar 12, 2016

Also, I think we need to do the same thing to PayFlow.

@angelleye angelleye closed this Mar 12, 2016

@angelleye angelleye reopened this Mar 12, 2016

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Mar 12, 2016

Collaborator

Amex card type only support AUD and USD currency as per this table. please correct me if I am wrong.

Collaborator

kcppdevelopers commented Mar 12, 2016

Amex card type only support AUD and USD currency as per this table. please correct me if I am wrong.

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Mar 12, 2016

Owner

You're correct. I was reading it incorrectly before.

Owner

angelleye commented Mar 12, 2016

You're correct. I was reading it incorrectly before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment