New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to force TLS 1.2 #463

Closed
angelleye opened this Issue May 12, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@angelleye
Owner

angelleye commented May 12, 2016

Lots of people are running into the POODLE issue still, but I don't want to hard code the TLS 1.2 option for everybody because servers that are configured correctly don't need it.

I do want to add an option where people can "Force TLS 1.2" and if this is enabled in the plugin then it would add the CURLOPT_SSLVERSION = 6 setting to the curl request to PayPal.

This will be a global plugin setting, so we can create a "Global" tab under Settings -> PayPal for WooCommerce -> General, and within that we'll add this new option.

Again, if enabled, all of the gateways should then force TLS 1.2 by adding that CURLOPT_SSLVERSION, which is something that will probably need to be adjusted in the class libraries directly. It's a simple line of code being added, but we'll need to pass some sort of option flag into the class/function to add it or not based on the option.

@angelleye angelleye added this to the 1.2.1 milestone May 12, 2016

@angelleye angelleye modified the milestones: 1.2, 1.2.1 Jun 11, 2016

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Jun 11, 2016

Owner

This is coming up a lot, so I'd like to go ahead and get it added to 1.2.0.

Owner

angelleye commented Jun 11, 2016

This is coming up a lot, so I'd like to go ahead and get it added to 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment