New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to undefined method InvalidArgumentException::getData() #472

Closed
scrobbleme opened this Issue Jun 9, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@scrobbleme

scrobbleme commented Jun 9, 2016

Got error 'PHP message: PHP Fatal error: Call to undefined method InvalidArgumentException::getData() in .../paypal-for-woocommerce/classes/wc-gateway-paypal-plus-angelleye.php on line 556

The problem there is, that you catch generic exceptions, but the getData is only defined on PayPalConnectionException.

Maybe getMessage would be better in this case.

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Jun 10, 2016

Owner

@scrobbleme Thanks for the feedback!

@kcppdevelopers You agree with this? If so, please go ahead and take care of it.

Owner

angelleye commented Jun 10, 2016

@scrobbleme Thanks for the feedback!

@kcppdevelopers You agree with this? If so, please go ahead and take care of it.

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Jun 10, 2016

Collaborator

Yes I am agree with this.

Collaborator

kcppdevelopers commented Jun 10, 2016

Yes I am agree with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment