New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing second argument for woocommerce_checkout_order_processed #530

Closed
michaelbeil opened this Issue Aug 11, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@michaelbeil

michaelbeil commented Aug 11, 2016

We noticed that the second argument on the woocommerce_checkout_order_processed action hook was missing, so we went ahead and added it on a customer's site. We use this hook in AffiliateWP, so it was causing a fatal on checkout since there was conflict between how we are using the hook and your plugin.

Lines in question:

Should be do_action( 'woocommerce_checkout_order_processed', $order_id, array() );.

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Aug 12, 2016

Owner

Thanks! We'll review and get it merged accordingly.

Owner

angelleye commented Aug 12, 2016

Thanks! We'll review and get it merged accordingly.

@michaelbeil

This comment has been minimized.

Show comment
Hide comment
@michaelbeil

michaelbeil Aug 12, 2016

Sounds good!

michaelbeil commented Aug 12, 2016

Sounds good!

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Aug 13, 2016

Collaborator

issue #502

Collaborator

kcppdevelopers commented Aug 13, 2016

issue #502

@michaelbeil

This comment has been minimized.

Show comment
Hide comment
@michaelbeil

michaelbeil Aug 13, 2016

Looks like it should be:

do_action( 'woocommerce_checkout_order_processed', $array );

michaelbeil commented Aug 13, 2016

Looks like it should be:

do_action( 'woocommerce_checkout_order_processed', $array );

@michaelbeil

This comment has been minimized.

Show comment
Hide comment
@michaelbeil

michaelbeil Aug 13, 2016

Well, what branch is the latest version of the plugin? I noticed master still has the second argument as array().

michaelbeil commented Aug 13, 2016

Well, what branch is the latest version of the plugin? I noticed master still has the second argument as array().

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Aug 13, 2016

Owner

The master branch is the currently released version, which as of now is 1.2.3.

The release branch is our default branch here and typically contains everything that has been completed and tested for the next update that we're working on.

The dev branch is where we work on that next update and resolve things.

Owner

angelleye commented Aug 13, 2016

The master branch is the currently released version, which as of now is 1.2.3.

The release branch is our default branch here and typically contains everything that has been completed and tested for the next update that we're working on.

The dev branch is where we work on that next update and resolve things.

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Aug 16, 2016

Collaborator

Look like it should be:

do_action( 'woocommerce_checkout_order_processed', $order_id, $this->posted );

https://github.com/woothemes/woocommerce/blob/master/includes/class-wc-checkout.php#L676

Collaborator

kcppdevelopers commented Aug 16, 2016

Look like it should be:

do_action( 'woocommerce_checkout_order_processed', $order_id, $this->posted );

https://github.com/woothemes/woocommerce/blob/master/includes/class-wc-checkout.php#L676

@michaelbeil

This comment has been minimized.

Show comment
Hide comment
@michaelbeil

michaelbeil Aug 17, 2016

Oh, good catch. I noticed that the second argument was $this->posted in WooCommerce core, but was not familiar with your codebase, but glad this got resolved.

Thanks all!

michaelbeil commented Aug 17, 2016

Oh, good catch. I noticed that the second argument was $this->posted in WooCommerce core, but was not familiar with your codebase, but glad this got resolved.

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment