New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jQuery triggers to fire when event listeners are attached #427

Closed
wants to merge 1 commit into
base: release
from

Conversation

Projects
None yet
3 participants
@woocommerce-00ser
Contributor

woocommerce-00ser commented Mar 10, 2016

Added 'angelleye_paypal_form_checkout_js_loaded' and 'angelleye_paypal_checkout_button_js_loaded' jQuery triggers.

Might be useful for themes/plugins that need to override the event-listener functions. There still might be lots of places that might benefit from triggers, but just these two are a lot of help since we wont have to modify any javascript, we can just redefine our own.

Note: jQuery triggers bubble up the DOM, so there is no need to attach the event listeners directly to the elements ".paypal_checkout_button" and "form.angelleye_checkout". You can attach them directly in document.body.

Added 'angelleye_paypal_form_checkout_js_loaded' and 'angelleye_paypa…
…l_checkout_button_js_loaded' jQuery triggers

@angelleye angelleye added this to the 1.2 milestone Mar 10, 2016

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Mar 10, 2016

Owner

@kcppdevelopers Please review this and let me know if you agree with the assessment.

Owner

angelleye commented Mar 10, 2016

@kcppdevelopers Please review this and let me know if you agree with the assessment.

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Mar 12, 2016

Collaborator

I have review this and I am agree with the assessment, I have merge this into the dev branch.

Collaborator

kcppdevelopers commented Mar 12, 2016

I have review this and I am agree with the assessment, I have merge this into the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment