New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confirm on capture and update order total amount without save o… #631

Merged
merged 4 commits into from Jan 27, 2017

Conversation

Projects
None yet
3 participants
@gine
Contributor

gine commented Jan 25, 2017

The action to capture the order is the most important action in the authorize/capture flow. So i have added to that action a js confirm that ask if the amount is correct.

To do that i need to have the value in "total order" field in the table "angelleye_order_action_table" updated each woocommerce order operation otherwise i show a bad value.

So i have added an observer to update this value at each operation on the div woocommerce-order-items.

@angelleye angelleye added this to the 1.3.2 milestone Jan 25, 2017

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Jan 25, 2017

Owner

@kcppdevelopers Please review and merge accordingly.

@gine, thanks again!

Owner

angelleye commented Jan 25, 2017

@kcppdevelopers Please review and merge accordingly.

@gine, thanks again!

@gine

This comment has been minimized.

Show comment
Hide comment
@gine

gine Jan 26, 2017

Contributor

work well with refund but maybe there is a problem with discount. tomorrow I will do a better test.

@angelleye you are welcome

Contributor

gine commented Jan 26, 2017

work well with refund but maybe there is a problem with discount. tomorrow I will do a better test.

@angelleye you are welcome

@gine

This comment has been minimized.

Show comment
Hide comment
@gine

gine Jan 26, 2017

Contributor

@angelleye i confirm that it works with discount too. In the last commit have fixed only the amount format:
FROM amount + currency_symbol TO currency_symbol + amount

Contributor

gine commented Jan 26, 2017

@angelleye i confirm that it works with discount too. In the last commit have fixed only the amount format:
FROM amount + currency_symbol TO currency_symbol + amount

@gine

This comment has been minimized.

Show comment
Hide comment
@gine

gine Jan 26, 2017

Contributor

Done

Contributor

gine commented Jan 26, 2017

Done

@angelleye angelleye modified the milestones: 1.4.0, 1.3.2 Jan 27, 2017

@angelleye angelleye modified the milestones: 1.3.2, 1.4.0 Jan 27, 2017

@kcppdevelopers kcppdevelopers merged commit e68f1b0 into angelleye:release Jan 27, 2017

angelleye added a commit that referenced this pull request Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment