Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Modules with assertions #213

Closed
angrykoala opened this issue Oct 6, 2018 · 0 comments
Closed

Generalize Modules with assertions #213

angrykoala opened this issue Oct 6, 2018 · 0 comments
Labels
enhancement Modifies or change a feature
Milestone

Comments

@angrykoala
Copy link
Owner

Instead of separate modules and assertion modules, make the assertions part of the browser modules. E.g.:

class MyModule extends BrowserModule{
    constructor(browser) {
        this._browser = browser;
    }

    _beforeOpen() {
        // BeforeOpen Hook
    }

    _beforeClose() {
        // beforeClose Hook
    }

   get assertions(){
     // return the assertions object of the module, if any
   }

After the assertions are defined, the assertions module will inject these in the browser.assert[my_module]

@angrykoala angrykoala added the enhancement Modifies or change a feature label Oct 6, 2018
@angrykoala angrykoala modified the milestones: 1.3, 1.4 Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Modifies or change a feature
Projects
None yet
Development

No branches or pull requests

1 participant