Add .mjs resolution to Native Federation esbuild adapter #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to allow ng-packagr output (.mjs) to be used in federation
Open
2 tasks
Daniel4o
force-pushed
the
bugfix/nf-esbuild-mjs-support
branch
from
7247b5c to
e482831
Compare
Collaborator
Daniel4o
force-pushed
the
bugfix/nf-esbuild-mjs-support
branch
from
e482831 to
c14092d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
resolveExtensionsto the NF Angular esbuild adapter so.mjsentrypoints are resolved alongside TS/JSContext
Shared/exposed packages that publish
index.mjsfail to resolve during NF builds (esbuild error: “Could not resolve …”) because.mjsisn’t in the default extensions list.Testing
Local NF build with a shared module that exposes an
index.mjsnow completes without resolution errors