Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Naming Question]: Would `eslint-angular` be better than `angular-eslint` #21

Closed
JounQin opened this issue Sep 25, 2019 · 3 comments
Closed

Comments

@JounQin
Copy link

@JounQin JounQin commented Sep 25, 2019

It would be more consistent with tslint-angular or any other ESLint related plugins.

And the GitHub/npm name is still available.

@mgechev

This comment has been minimized.

Copy link

@mgechev mgechev commented Sep 25, 2019

Looking at npm the suggestion makes sense to me. Most of the plugins are with eslint- prefix. @JamesHenry, since you've been involved in this ecosystem for a while now would you chip in?

@JamesHenry

This comment has been minimized.

Copy link
Collaborator

@JamesHenry JamesHenry commented Sep 25, 2019

It’s not an apples to apples comparison.

‘eslint-‘ has a special meaning for resolving plugins, and we do indeed leverage that here.

The name of the organisation/monorepo is orthogonal to that. “angular-eslint” is not the name of a package here, you don’t install that ever.

@angular-eslint as a namespace under which our packages live is much easier to scan for in an an eslint config file IMO and it matches the @typescript-eslint namespace upon which this project builds.

My opinion would strongly be for not changing it.

@JamesHenry

This comment has been minimized.

Copy link
Collaborator

@JamesHenry JamesHenry commented Sep 25, 2019

(I’m away from my computer otherwise I would have provided more config and code examples to illustrate my point but hopefully it’s clear, happy to expand further later)

@mgechev mgechev closed this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.