Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration from 1 to 2 creates .eslintrc.json when you have a .eslintrc.js file already #380

Closed
bbarry opened this issue Mar 17, 2021 · 4 comments · Fixed by #419
Closed
Labels
package: schematics Angular CLI schematics which are responsible for configuration generation and automated migrations triage This issue needs to be looked at and categorized by a maintainer

Comments

@bbarry
Copy link

bbarry commented Mar 17, 2021

steps to reproduce:

  1. have @angular-eslint 1.2.0 installed and configured with .eslintrc.js file
  2. update with ng update @angular-eslint/schematics

after update you will have a file .eslintrc.json with the contents {}

@bbarry
Copy link
Author

bbarry commented Mar 17, 2021

I think if you have an .eslintrc.js file, the migration should skip the part about updating .eslintrc.json and direct you to read about the breaking changes,

@ahnpnl
Copy link

ahnpnl commented Mar 25, 2021

I observed the same thing. After migration, I was a bit lost of what should be changed in my js configuration to be compatible with v2

@bbarry
Copy link
Author

bbarry commented Mar 25, 2021

@ahnpnl (and anyone else finding this issue) remove use-pipe-decorator from your config if you have it there and delete the .json file that was added.

@JamesHenry JamesHenry added package: schematics Angular CLI schematics which are responsible for configuration generation and automated migrations triage This issue needs to be looked at and categorized by a maintainer labels Mar 27, 2021
@JamesHenry
Copy link
Member

I have explicitly documented our policy on custom ESLint config file types: https://github.com/angular-eslint/angular-eslint#notes-on-supported-eslint-configuration-file-types

Additionally, I will endeavor to make release notes for major versions as clear as possible for folks who are not using the automated migrations from now.

Many thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: schematics Angular CLI schematics which are responsible for configuration generation and automated migrations triage This issue needs to be looked at and categorized by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants