Skip to content

Conversation

@FonecaBot2
Copy link

No description provided.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Nov 2, 2022

View your CI Pipeline Execution ↗ for commit de879f0.

Command Status Duration Result
nx run-many -t build ✅ Succeeded 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-17 14:16:15 UTC

@pumano
Copy link
Contributor

pumano commented Nov 15, 2022

@FonecaBot2 good rule, but as I understand you need add some tests and generate documentation using command from package.json

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pumano feedback is correct

@FonecaBot2
Copy link
Author

@FonecaBot2 good rule, but as I understand you need add some tests and generate documentation using command from package.json

Sure! I'll do that

@JamesHenry
Copy link
Member

@FonecaBot2 hopefully you can see the formatting failure, I would suggest running the main items from the ci.yml file locally before pushing up (you shouldn't need to run the integration-tests though)

@JamesHenry
Copy link
Member

@FonecaBot2 Please advise on if you intend to complete this PR?

@Friendseeker
Copy link
Contributor

@FonecaBot2 Please advise on if you intend to complete this PR?

If the original PR author is gone, I think I can take over this PR.

@JamesHenry
Copy link
Member

@Friendseeker Thanks very much! Please feel free to open a new PR, I'll close this one for clarity.

Thanks again for starting this off @FonecaBot2!

@JamesHenry JamesHenry closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants