-
Notifications
You must be signed in to change notification settings - Fork 251
feat(eslint-plugin): [input-not-event-emitter] add rule #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [input-not-event-emitter] add rule #1173
Conversation
|
View your CI Pipeline Execution ↗ for commit de879f0.
☁️ Nx Cloud last updated this comment at |
|
@FonecaBot2 good rule, but as I understand you need add some tests and generate documentation using command from package.json |
JamesHenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pumano feedback is correct
Sure! I'll do that |
|
@FonecaBot2 hopefully you can see the formatting failure, I would suggest running the main items from the ci.yml file locally before pushing up (you shouldn't need to run the integration-tests though) |
|
@FonecaBot2 Please advise on if you intend to complete this PR? |
If the original PR author is gone, I think I can take over this PR. |
|
@Friendseeker Thanks very much! Please feel free to open a new PR, I'll close this one for clarity. Thanks again for starting this off @FonecaBot2! |
No description provided.