feat(lib): provide store functionality #185
Conversation
| const resolveStoreEnhancer = storeEnhancer => isString(storeEnhancer) | ||
| ? $injector.get(storeEnhancer) | ||
| : storeEnhancer; | ||
| return createNgReduxStore($injector, _middlewares, _storeEnhancers, _reducer, _initialState); |
There was a problem hiding this comment.
the diff looks a bit weird but I basically moved the this.$get logic out into its own function so that we can create stores on-demand.
| .subscribe(() => { | ||
| let newState = providedStore.getState(); | ||
|
|
||
| ngReduxStore.dispatch(newState); |
There was a problem hiding this comment.
here's where the magic happens. The only thing I'm unsure about is cleanup. But as I understand it, Angular 1 never really "unloads" during runtime so this shouldn't be an issue.
| }) | ||
| ; | ||
|
|
||
| return Object.assign({}, |
There was a problem hiding this comment.
Is the intention to not provide .connect() functionality when using a provided store? I fiddled with it and added it back in, the only caveat is that connected actions dispatch to the wrong store, so you always need to use the $ngRedux.dispatch.
| const resolveReducerKey = (result, key) => assign({}, result, | ||
| { [key]: getReducerKey(key) } | ||
| ); | ||
| function createNgReduxStore($injector, _middlewares, _storeEnhancers, _reducer, _initialState) { |
There was a problem hiding this comment.
By moving this function out, i'm getting _reducerIsObject is not defined, on line 77. Looks like it doesn't have the scope of all the vars defined at the top of ngReduxProvider()
There was a problem hiding this comment.
I resolved it for myself by moving createNgReduxStore inside of the ngReduxProvider method's scope but i'm not sure if that was a good solution or not.
| ? $injector.get(middleware) | ||
| : middleware; | ||
| if (_providedStore) { | ||
| const emptyStore = createNgReduxStore($injector, [], [], state => state, undefined); |
There was a problem hiding this comment.
This pass through reducer is throwing errors for me. It's expecting it to be a well formed action object {type: 'foobar'}.
Changed to (state, action) => action.payload and then changed line 6 of the store wrapper to just dispatch as:
ngReduxStore.dispatch({type:'@@NGREDUX_PASSTHROUGH', payload: newState});
There was a problem hiding this comment.
Ah! nice! I figured that might cause some issues.
|
@derrickpelletier thanks for all the feedback! I'll have to get back to this once I get a chance. If you want to take over the branch and push the fixes you've got, you're more than welcome to. |
|
Happy to, will push something soon. |
|
@AntJanus how would you suggest going about it? I branched off yours, can PR into your branch or just re-submit the PR? |
|
@derrickpelletier resubmit it and I'll just close this one out. Thanks for the hard work! :) |
Ref: #19
@deini would love some input on this. Here's the idea:
I haven't tested this out yet.