From 5184fc67419ff3b3dccc1948a0d1757eacd47a16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=BB=84=E5=BB=BA?= Date: Sun, 13 Sep 2015 09:43:51 +0800 Subject: [PATCH 1/2] Fixed #20: bind $rootScope.$apply context; --- examples/counter/devTools.js | 2 +- examples/counter/package.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/counter/devTools.js b/examples/counter/devTools.js index 892a090..0ddeee5 100644 --- a/examples/counter/devTools.js +++ b/examples/counter/devTools.js @@ -10,7 +10,7 @@ angular.module('counter') ); //Hack to reflect state changes when disabling/enabling actions via the monitor $ngRedux.subscribe(_ => { - setTimeout($rootScope.$apply, 100); + setTimeout($rootScope.$apply.bind($rootScope), 100); }); }); diff --git a/examples/counter/package.json b/examples/counter/package.json index 21eea56..4a126ba 100644 --- a/examples/counter/package.json +++ b/examples/counter/package.json @@ -29,6 +29,7 @@ "angular": "^1.4.4", "ng-redux": "^2.0.0", "redux": "^2.0.0", + "redux-devtools": "^2.1.0", "redux-thunk": "^0.1.0" } } From 77e6f896745674541dbb5efa9cc9113d582be04b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=BB=84=E5=BB=BA?= Date: Sun, 13 Sep 2015 10:02:05 +0800 Subject: [PATCH 2/2] fix: Corrects target type to 'object' instead of 'plain object' in comment --- src/components/connector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/connector.js b/src/components/connector.js index ae31855..f0cdf1b 100644 --- a/src/components/connector.js +++ b/src/components/connector.js @@ -33,7 +33,7 @@ export default function Connector(store) { invariant( _.isFunction(target) || _.isObject(target), - 'The target parameter passed to connect must be a Function or a plain object.' + 'The target parameter passed to connect must be a Function or a object.' ); //Initial update