Skip to content

Fixed #20: bind $rootScope.$apply context; #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2015
Merged

Fixed #20: bind $rootScope.$apply context; #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5184fc6
Fixed #20: bind $rootScope.$apply context;
sandwich99 Sep 13, 2015
77e6f89
fix: Corrects target type to 'object' instead of 'plain object' in co…
sandwich99 Sep 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/counter/devTools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ angular.module('counter')
);
//Hack to reflect state changes when disabling/enabling actions via the monitor
$ngRedux.subscribe(_ => {
setTimeout($rootScope.$apply, 100);
setTimeout($rootScope.$apply.bind($rootScope), 100);
});
});

Expand Down
1 change: 1 addition & 0 deletions examples/counter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"angular": "^1.4.4",
"ng-redux": "^2.0.0",
"redux": "^2.0.0",
"redux-devtools": "^2.1.0",
"redux-thunk": "^0.1.0"
}
}
2 changes: 1 addition & 1 deletion src/components/connector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function Connector(store) {

invariant(
_.isFunction(target) || _.isObject(target),
'The target parameter passed to connect must be a Function or a plain object.'
'The target parameter passed to connect must be a Function or a object.'
);

//Initial update
Expand Down