From 0aab9f4da56d2bdbba840f266f61c93652429c31 Mon Sep 17 00:00:00 2001 From: Laurent Goudet Date: Mon, 15 Jul 2019 11:16:36 +0200 Subject: [PATCH] Don't update golden image if unchanged --- screenshot_helper/screenshot_helper.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/screenshot_helper/screenshot_helper.ts b/screenshot_helper/screenshot_helper.ts index 5bf91f1..157afd6 100644 --- a/screenshot_helper/screenshot_helper.ts +++ b/screenshot_helper/screenshot_helper.ts @@ -38,9 +38,9 @@ export async function compareScreenshot(data, golden, outputFolder = undefined): const screenshotPath = await writeScreenshot(tempFolder, data); // check if goldens need to be updated const update = process.env['UPDATE_GOLDENS'] === '1' || process.env['UPDATE_GOLDENS'] === 'true'; - if (update) { + if (update && !fs.existsSync(golden)) { fs.writeFileSync(golden, fs.readFileSync(screenshotPath)); - resolve('Reference image ' + golden +' was successfully updated.'); + resolve('Reference image ' + golden + ' was successfully updated.'); return; } const goldenName = path.basename(golden); @@ -53,7 +53,10 @@ export async function compareScreenshot(data, golden, outputFolder = undefined): return; } if (!equal) { - if (outputFolder) { + if (update) { + fs.writeFileSync(golden, fs.readFileSync(screenshotPath)); + resolve('Reference image ' + golden + ' was successfully updated.'); + } else if (outputFolder) { const diffPath = path.join(outputFolder, `diff-${goldenName}`); looksSame.createDiff({ reference: golden,