This repository was archived by the owner on Nov 30, 2018. It is now read-only.
lodash 4 compatibility #1694
Merged
lodash 4 compatibility #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: I didnt use bower within angular-google-maps to specify that angular-google-maps should itself use lodash 4. I did in my own project's bower.json to bump up the lodash version to 4 to test (if that makes sense). |
Contributor
Author
|
hey nmccready... I might have one more update. the spacing might be wrong on the coffeescript... one sec. |
Contributor
|
Just submit another PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I had trouble compiling and creating the JS files at home on my machine but I think it compiled fine at work earlier (if you can compile and create the files from the coffeescript that would be great.)