This repository was archived by the owner on Nov 30, 2018. It is now read-only.
Improvе "center" watcher "ui-gmap-circle" directive for "geoJSON" compatibility #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "coordinates" reference checking and object reference checking of "geoJSON" to $watchCollection for "ui-gmap-circle" directive
AbstractVisions
changed the title
Contributor
There was a problem hiding this comment.
To be safe here _.isEqual newVals,oldVal should have () as the parser somtimes dudges this _.isEqual(newVals,oldVal).
Contributor
There was a problem hiding this comment.
Please run grunt to make sure the specs pass locally. But you can revert the dist changes. on PR
Contributor
Author
There was a problem hiding this comment.
Yes, you are right. I will fix it!
Contributor
|
Lgtm |
nmccready
added a commit
that referenced
this pull request
Jan 22, 2016
Improvе "center" watcher "ui-gmap-circle" directive for "geoJSON" compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "coordinates" reference checking and object reference checking of "geoJSON" to $watchCollection for "ui-gmap-circle" directive
#1679