Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Tabs vs Spaces #165

Closed
ProLoser opened this Issue · 22 comments

6 participants

@ProLoser
Owner

I think the inconsistency is starting to become a problem. Of course it could just be that we must give people explicit instructions NOT to change the indentation format. Or we could just hold a vote and convert everything over to the new format in the next release.

@boneskull
@ProLoser
Owner

Why do people like spaces?

@pkozlowski-opensource

+1 for deciding and re-formatting everything now and stick to it. As soon as we've got the decision I could change formatter in my IDE and would stop worrying about reformating the whole file. This change would also make lint happy as today it complains about mixed tabs and spaces.

As for votes, I really don't mind either way, spaces, tabs, whatever, as long as it is consistent.

@ajoslin
Owner
@dandoyon
Owner
@petebacondarwin
@boneskull
@dandoyon
Owner

I do have to say, I've been pretty fine with 2 spaces

@boneskull
@boneskull
@boneskull
@pkozlowski-opensource

So, from now on we are using 2 spaces :-)

@pkozlowski-opensource

Just a comment on coffee usage triggered by @boneskull. So, first of all I don't know coffee - I saw some examples and found them hard to read so kind of stayed away from it. It is probably just my ignorance / lack of experience but all in all I'm not great fan of coffee. I don't mind other people using it, it is just that at the moment it is a barrier for me to actively help with directives written in coffee.

For now I see 2 practical problems with coffee:

  • it might be putting off people not familiar with it (but once again, maybe the solution is to make other people learn & appreciate)
  • it makes build a bit more complex: for instance today I wanted to exclude *.coffee.js from lint task and hit a wall; once again this is probably due to my lack of knowledge / experience....

Just my 3 cents here....

@dandoyon
Owner
@ajoslin
Owner
@petebacondarwin
@petebacondarwin
@ProLoser
Owner

I realize if we all adopted CS it would probably be a lot better, but my biggest frustration with HarvestHQ/Chosen was that it was written in CS. It exponentially increased the difficulty for me to contribute as I had never worked with CS before. That is slightly a concern for me for our users since this lib is almost as much a learning and example tool as it is a utility suite.

@ProLoser ProLoser reopened this
@petebacondarwin
@ProLoser
Owner

Wait I realize I've been completely out voted but I really want to know, WHY does everyone hate tabs? I have heard 'tabs are evil' a lot but never understood why.

I have always been against spaces for 2 reasons:

  • You force people to indent their code how YOU think it should be, rather than letting them choose.
  • A tab is 1 physical indentation character. Not everyone has shiny (or smart) IDE's.

I am quite aware that I'm outnumbered on more than just this project however.

Edward's reason against tabs used to be that it didn't "look pretty" when viewed on Github but that sort of seemed like a silly excuse to change how you code.
I figure if a tab character was used, the question of 2 vs 4 spaces would be irrelevant.

@ProLoser
Owner

We can't have both generated JS and CS files next to each other. It would create an inconsistency similar to what we've been seeing with building the project.

@petebacondarwin looks like you and I will have to be backing down lol.

@ProLoser ProLoser closed this
@ajoslin
Owner

Dean, I like 2 spaces better than tabs because 2 spaces always look two-wide in every editor, while a tab will look like 4 in some places, 8 in some places, or two in others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.