This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Fixes for the reset issue #149 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We need to discuss tab length. I prefer 4, others prefer 2, but I don't want to see a bunch of commits that just clobber other people's lengths. |
Contributor
|
I see what I missed before in this test; checking the val() of the text field. Looks good to me. |
boneskull
pushed a commit
that referenced
this pull request
Aug 18, 2012
Fixes for the reset issue #149
Member
Author
|
+1 for discussing formatting. I don't mind either way (spaces, tabs, whatever the length) but it would be good to agree on something. AngularJS uses tabs of 2 AFAIK. Anyway, whatever the decision we should have more or less consistent formatting - otherwise merges get kind of messy (noticed it with this PR). I will send a quick e-mail to the angular-ui so we can discuss this. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149. Updated tests as well to expose the issue (basically input wasn't repaint). Changed the implementation a bit so it works even without jQuery (tests still need jQuery). Fixes #149