Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding a new Auth module #196

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Owner

ProLoser commented Sep 12, 2012

WIP! Do not merge. Tests are stubbed but incomplete. Trying to figure out how to test out $broadcast

Dean Sofer added some commits Sep 12, 2012

Owner

petebacondarwin commented Sep 13, 2012

Is there any need to have this in the main repository? If it is not ready
can't it stay in your own private repository?

Pete
...from my mobile.
On Sep 12, 2012 10:19 PM, "Dean Sofer" notifications@github.com wrote:

WIP! Do not merge. Tests are stubbed but incomplete. Trying to figure out

how to test out $broadcast

You can merge this Pull Request by running:

git pull https://github.com/angular-ui/angular-ui auth

Or view, comment on, or merge it at:

angular-ui#196
Commit Summary

  • Adding a new Auth module

File Changes

  • A modules/auth/auth.js (82)
  • A modules/auth/test/authSpec.js (44)

Patch Links

Owner

ProLoser commented Sep 13, 2012

I have it in both. I was putting it in the main repo (as a branch) for
other people to hack on because I sort of picked that up from pawel. I
think you may be right that I (we) should not clutter the primary repo with
WIP branches. Next chance I get I will ensure my fork has up-to-date
versions and remove the branches from this fork.

On Wed, Sep 12, 2012 at 10:50 PM, Pete Bacon Darwin <
notifications@github.com> wrote:

Is there any need to have this in the main repository? If it is not ready
can't it stay in your own private repository?

Pete
...from my mobile.
On Sep 12, 2012 10:19 PM, "Dean Sofer" notifications@github.com wrote:

WIP! Do not merge. Tests are stubbed but incomplete. Trying to figure
out

how to test out $broadcast

You can merge this Pull Request by running:

git pull https://github.com/angular-ui/angular-ui auth

Or view, comment on, or merge it at:

angular-ui#196
Commit Summary

  • Adding a new Auth module

File Changes

  • A modules/auth/auth.js (82)
  • A modules/auth/test/authSpec.js (44)

Patch Links


Reply to this email directly or view it on GitHub<
https://github.com/angular-ui/angular-ui/pull/196>.


Reply to this email directly or view it on GitHubhttps://github.com/angular-ui/angular-ui/pull/196#issuecomment-8518844.

Dean J Sofer
DeanSofer@gmail.com

BS Computer Information Systems
California State Polytechnic University, Pomona
Telephone: 714-900-2254
Website: www.DeanSofer.com
Github: github.com/ProLoser

@ProLoser ProLoser closed this Sep 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment