Permalink
Browse files

chore(jshint): make JSHint configuration stricter

- Check for usage of undefined variables
- Add basic Jasmine globals so that spec files pass JSHint
- Ensure that angular variable can't be re-defined (set to false)

Closes #2861
  • Loading branch information...
1 parent ca6fad6 commit 42011f0665246896ff34823f9d7a571baef4a721 @chrisirhc chrisirhc committed Oct 20, 2014
Showing with 18 additions and 1 deletion.
  1. +17 −1 .jshintrc
  2. +1 −0 Gruntfile.js
View
@@ -8,7 +8,23 @@
"eqnull": true,
"quotmark": "single",
"trailing": true,
+ "undef": true,
+ "browser": true,
+ "jquery": true,
"globals": {
- "angular": true
+ "angular": false,
+
+ // For Jasmine
+ "after" : false,
+ "afterEach" : false,
+ "before" : false,
+ "beforeEach" : false,
+ "describe" : false,
+ "expect" : false,
+ "jasmine" : false,
+ "module" : false,
+ "spyOn" : false,
+ "inject" : false,
+ "it" : false
}
}
View
@@ -1,3 +1,4 @@
+/* jshint node: true */
var markdown = require('node-markdown').Markdown;
module.exports = function(grunt) {

0 comments on commit 42011f0

Please sign in to comment.