Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

bug(modal) - modal scope is not destroyed on close #1643

Closed
Halama opened this issue Jan 22, 2014 · 24 comments
Closed

bug(modal) - modal scope is not destroyed on close #1643

Halama opened this issue Jan 22, 2014 · 24 comments

Comments

@Halama
Copy link

Halama commented Jan 22, 2014

Hi,
since version 0.10.0 modal $scope isn't destroy on modal close.
There are examples of this behaviour, please open browser console while testing.

Example using 0.10.0 (There is a bug):
http://plnkr.co/edit/luXIk8fRD3RaRYvFXUCA?p=preview

Example using 0.9.0 (Works fine):
http://plnkr.co/edit/qLAcaEcGryXOhBXoKp6v?p=preview

thanks

@Foxandxss
Copy link
Contributor

You're right. I need to research more on it. @pkozlowski-opensource thoughts?

@pkozlowski-opensource
Copy link
Member

yup, this is a bug, side-effect of supporting close animations. Pretty easy fix, tests are not so obvious to write :-)

@chrisirhc
Copy link
Contributor

Interesting, I must've introduced it. Need to account for this when using nganimate.

@pkozlowski-opensource
Copy link
Member

@chrisirhc I will push a quick fix in a sec but yes, $animate will be a proper solution

@chrisirhc
Copy link
Contributor

Cool thanks! Yep I'll look into it.

@asapach
Copy link

asapach commented Mar 18, 2014

Guys, that's a pretty critical bug. Could you please backport the fix to the 0.10 branch/tag if 0.11 is too far away.

@gazsp
Copy link

gazsp commented May 1, 2014

Is there any news on this for v0.10?

Ignore me. Just patched my source for now.

@JasonRodman
Copy link

Any idea when this will be fixed?

@asapach
Copy link

asapach commented Jun 5, 2014

I believe it's already fixed in 0.11: http://plnkr.co/edit/iuaRN1L07ojBbqyMyIpx?p=preview

@JasonRodman
Copy link

I just upgraded to 0.11 and the event still does not fire.

@JasonRodman
Copy link

For some unexplained reason it just started working. Cant figure out why.

@aymericbeaumet
Copy link

Hey Pawel,

I still encounter this issue in both 0.10 and 0.11. Has this been fixed in the latest stable version?

@segevofer
Copy link

Hey Pawel,
me too! any news about this bug?

@spotlmnop
Copy link

Same here, I can still see this bug.

@neoblackcap
Copy link

I use the 0.11 version, and the event can be triggered. I think this bug has been fixed.

@spotlmnop
Copy link

Yes, 0.11 fixes this issue. If someone here is working 1.3.0 angular , the only supported version is 1.3.0-beta.10. Else, typeahead does not work. Hope this helps someone.

@ribbitfix
Copy link

I was having this issue on 0.11, but figured out that I was calling .close() twice.

@DmitryEfimenko
Copy link

I still experience the issue.
Running:
angular v1.3.0-beta.11
angular-ui-bootstrap v0.11.0

@chrisirhc
Copy link
Contributor

@karianna , let's not be hasty to reopen this. #3308 doesn't explain what's broken and doesn't have a reproduction.

@citosid
Copy link

citosid commented May 20, 2015

@chrisirhc did you find any solution?

@DannyFeliz
Copy link

I can't believe that this bug still messing around at this time. 👎

@AndrewIsh
Copy link

I am experiencing this with v1.3.3. Would it be possible to re-open this issue, as far as I can see it is unresolved.

@barne397
Copy link

barne397 commented Jun 9, 2016

@AndrewIsh, I was just posting that I'm also having issues with v1.3.3, but turns out I had failed to account for an isolate scope on the directive where I was listing for the destroy event. So, I was listening to the wrong scope. It was getting destroyed, I just wasn't seeing the event.

Just wanted to mention that in case you're doing something similar.

@amonsot890
Copy link

any clear solutions on this .?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests