This repository has been archived by the owner on May 29, 2019. It is now read-only.
Accordion: don't toggle open class when is-open is undefined #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `is-open` is not set the accordion group is closed, but the open class will be toggled, because jQuery expects a string or boolean (ignores undefined). See here: https://github.com/jquery/jquery/blob/c9cf250daafe806818da1dd207a88a8e94a4ad16/src/attributes/classes.js#L105
| @@ -82,7 +82,7 @@ angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse']) | |||
| scope.openClass = attrs.openClass || 'panel-open'; | |||
| scope.panelClass = attrs.panelClass; | |||
| scope.$watch('isOpen', function(value) { | |||
| element.toggleClass(scope.openClass, value); | |||
| element.toggleClass(scope.openClass, Boolean(value)); | |||
There was a problem hiding this comment.
I would change this to !!value - the reason is because the Boolean constructor can be overridden by the user, whereas using !! to force to a Boolean cannot be overridden.
|
Scratch that, made the change - c064748 . Thanks for the find! |
|
Thanks! |
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
- Coerce `toggleClass` argument to boolean due to jQuery ignoring `undefined` Closes angular-ui#4385
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
is-openis not set the accordion group is closed, but the open class will be toggled, because jQuery expects a string or boolean (ignores undefined). See here: https://github.com/jquery/jquery/blob/c9cf250daafe806818da1dd207a88a8e94a4ad16/src/attributes/classes.js#L105