This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(typeahead): apply angular watch to the typeahead-editable setting #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,10 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap | |||
|
|
|||
| //should it restrict model values to the ones selected from the popup only? | |||
| var isEditable = originalScope.$eval(attrs.typeaheadEditable) !== false; | |||
| originalScope.$watch(attrs.typeaheadEditable, function (newVal) { | |||
| isEditable = newVal !== false; | |||
| modelCtrl.$setValidity('editable', isEditable); | |||
There was a problem hiding this comment.
This is a breaking change, and editable state should not be related to ngModel's validity. This is a bad change.
|
This needs tests. The model $setValidity call needs to be removed as well. |
|
Thanks for your patience. On Thu, Nov 5, 2015 at 5:54 PM, Wesley Cho notifications@github.com wrote:
|
|
I would be willing to accept this feature with the necessary changes. Noting for reference, this would implement #2638. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a watch for the typeahead-editable attribute.