Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(datepicker): alternate input formats: update datepicker on change #5014

Closed

Conversation

davious
Copy link
Contributor

@davious davious commented Dec 4, 2015

When and after typing an alternate format, the datepicker doesn't update, leading to confusion.

http://plnkr.co/edit/Qbx9hft21S9PAS0pqJ5i?p=preview

Review on Reviewable

@davious davious force-pushed the datepicker-alt-input-formats branch from 7964663 to 00513e7 Compare December 5, 2015 01:48
@davious davious force-pushed the datepicker-alt-input-formats branch from 00513e7 to bdab729 Compare December 5, 2015 01:50
@davious davious changed the title fix(datepicker): alternate input formats: setViewValue on parse fix(datepicker): alternate input formats: update the datepicker Dec 5, 2015
@wesleycho
Copy link
Contributor

This is the wrong approach - parseDate is a $parser for ngModel, one should never be calling $setViewValue there.

@davious davious changed the title fix(datepicker): alternate input formats: update the datepicker fix(datepicker): alternate input formats: update datepicker on change Dec 5, 2015
@wesleycho
Copy link
Contributor

This looks a lot better - good work!

@wesleycho wesleycho added this to the 1.0.0 milestone Dec 5, 2015
@wesleycho wesleycho closed this in fd88dcb Dec 5, 2015
@davious davious deleted the datepicker-alt-input-formats branch December 28, 2015 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants