This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly resetMatches when showing matches. #3119
Closed
Conversation
Make the dismissClickHandler less aggressive by only resetting matches when matches are being shown. Use $apply insetad of $digest.
|
This needs tests around the $apply change. If that change is undone and $digest is kept, I would be happy to merge this as is though. |
|
Merging this without $apply change. |
tmcgee123
pushed a commit
to tmcgee123/bootstrap
that referenced
this pull request
Aug 10, 2015
- Resets matches only when matches are present to avoid extra $digest Closes angular-ui#3119
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mwinkels commentedDec 17, 2014
Make the dismissClickHandler less aggressive by only resetting matches when matches are being shown. Use $apply insetad of $digest.