This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove trim() function when compiling tplContent #3132
Closed
Conversation
the trim() function is not supported in IE8 and removing it doesn't seem to affect the template compilation at all... There are no other changes required to typeahead in order to make it work on IE8 with AngularJS 1.2.x
|
We do not officially support IE8 - have you tested this change in IE9 - 11, Safari 7 & 8, Firefox, and Chrome? |
|
Actually, I am going to close this, as we are fully breaking with IE8 in our next release 0.13.0 soon, and current master already is incompatible with IE8 with Angular 1.3 as a hard requirement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
robertjf commentedDec 22, 2014
the trim() function is not supported in IE8 and removing it doesn't seem to affect the template compilation at all...
There are no other changes required to typeahead in order to make it work on IE8 with AngularJS 1.2.x