Skip to content
This repository has been archived by the owner. It is now read-only.

Update modal.js #3133

Closed
wants to merge 1 commit into from
Closed

Update modal.js #3133

wants to merge 1 commit into from

Conversation

@FDiskas
Copy link

FDiskas commented Dec 22, 2014

Allow scope to windowTemplateUrl Now its not working. In windowTemplate cant add some buttons to close the modal and pass additional info like title or something.
there is an not working example. http://plnkr.co/edit/mysjPOXA68NiaXcqDKvA?p=preview
By edditing a modalWindow directive its posible to do all the stuf.
closes #3134

Allow scope to windowTemplateUrl Now its not working. In windowTemplate cant add some buttons to close the modal and pass additional info like title or something.
there is an not working example. http://plnkr.co/edit/mysjPOXA68NiaXcqDKvA?p=preview
By edditing a modalWindow directive its posible to do all the stuf.
@jareddlc
Copy link

jareddlc commented Mar 13, 2015

+1

@karianna karianna added this to the 0.13.0 milestone Mar 14, 2015
@karianna
Copy link
Contributor

karianna commented Mar 14, 2015

@FDiskas Are you able to add some tests for this?

@FDiskas
Copy link
Author

FDiskas commented Mar 14, 2015

@karianna Sorry no

@wesleycho
Copy link
Member

wesleycho commented Mar 15, 2015

This looks like this would break the animation toggle of the in class with ng-class (see https://github.com/angular-ui/bootstrap/blob/master/template/modal/window.html ) - is there any reason why you can't add the buttons directly to the modal window through the transcluded template?

@wesleycho
Copy link
Member

wesleycho commented Mar 15, 2015

Ahh, I understand what the issue is now - I am going to close this in favor of #3390, as this should solve the problem in a non-breaking fashion.

@wesleycho wesleycho closed this Mar 15, 2015
@FDiskas FDiskas deleted the FDiskas:patch-1 branch Mar 16, 2015
@FDiskas
Copy link
Author

FDiskas commented Mar 16, 2015

Thanks

@chrisirhc chrisirhc removed this from the 0.13.0 milestone Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.