This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate modal.js #3133
Closed
Update modal.js #3133
Conversation
Allow scope to windowTemplateUrl Now its not working. In windowTemplate cant add some buttons to close the modal and pass additional info like title or something. there is an not working example. http://plnkr.co/edit/mysjPOXA68NiaXcqDKvA?p=preview By edditing a modalWindow directive its posible to do all the stuf.
jareddlc
commented
Mar 13, 2015
|
+1 |
|
@FDiskas Are you able to add some tests for this? |
|
@karianna Sorry no |
|
This looks like this would break the animation toggle of the |
|
Ahh, I understand what the issue is now - I am going to close this in favor of #3390, as this should solve the problem in a non-breaking fashion. |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
FDiskas commentedDec 22, 2014
Allow scope to windowTemplateUrl Now its not working. In windowTemplate cant add some buttons to close the modal and pass additional info like title or something.
there is an not working example. http://plnkr.co/edit/mysjPOXA68NiaXcqDKvA?p=preview
By edditing a modalWindow directive its posible to do all the stuf.
closes #3134