Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): add pluggable resolve support #5078

Closed
wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • Adds support for pluggable resolvers, namely for supporting UI Router's resolve handling

Feature in action here.

This implements #3405.

@icfantv
Copy link
Contributor

icfantv commented Dec 15, 2015

This is pretty slick @wesleycho. Nice work.

@Foxandxss
Copy link
Contributor

I am good but the docs doesn't conform the design I have now. But not sure how to do it either.

@Foxandxss
Copy link
Contributor

Also if post 1.0 is not going to have it, it is a bit "temporary"

@wesleycho
Copy link
Contributor Author

Well, I am talking with the UI Router folks, it's trivial to re-add support & they're open to it, but it may require a documentation update to explain how to use it afterwards.

@Foxandxss
Copy link
Contributor

That guy with sunglasses called @christopherthielen pss.

LGTM, it is a good addition indeed. I like our modal API like ng1 routes.

Let see what we achieve with ngbs.

@Foxandxss
Copy link
Contributor

Oh wait, forgot about the doc thing.

- Adds support for pluggable resolvers, namely for supporting UI Router's resolve handling
@Foxandxss
Copy link
Contributor

LGTM

@wesleycho wesleycho closed this in 2635f0d Dec 16, 2015
@wesleycho wesleycho deleted the feat/modal-resolve branch December 16, 2015 00:22
@aphillipspq
Copy link

aphillipspq commented Apr 17, 2017

@wesleycho @icfantv Has this been discontinued in the current version 2.5.0?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants