Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded new option to download CSV file directly without showing CSV Export button #1306
Conversation
…dded new downloadCSV() function to download the CSV file.
|
Will fail the build because it's missing a semicolon. Please fix and resubmit. |
|
@c0bra By any chance would you tell me which line is missing semicolon, I tried to do jslint and I don't see any error on missing semicolon |
|
@chandramuralis I just looked at the travis build output: https://travis-ci.org/angular-ui/ng-grid/builds/30471656#L876 |
This was referenced Aug 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chandramuralis commentedJul 21, 2014
Added an option to exclude CSVExport button from Grid footer panel, added new downloadCSV() function to download the CSV file.
To hide CSV export button from hide set 'inhibitButton' value to true in the CSV options.
CSV options now accepts new parameter 'downloadFileName', downloadCSV function will use this parameter to name the file name.