Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure minWidth and maxWidth are applied correctly #1852

Closed
wants to merge 1 commit into from

Conversation

@baabgai
Copy link

baabgai commented Oct 17, 2014

When splicing an element of the percentArray or asteriksArray within a
loop certain array elements would be skipped during processing if the
counter is not decremented.

When splicing an element of the percentArray or asteriksArray within a
loop certain array elements would be skipped during processing if the
counter is not decremented.
@PaulL1
Copy link
Contributor

PaulL1 commented Oct 17, 2014

I believe this will be superseded when we merge #1768. Could you check if your problem persists in that code, if not then we can close this, if it does, could you suggest a modification against that commit?

Thanks,

@baabgai
Copy link
Author

baabgai commented Oct 22, 2014

The problem seems to be solved for the ui-grid-header.js directive and my
original problem disappeared. The #1768 issue does not touch the
GridRenderContainer.js so there the problem of missing every other array
item within the loop would still be present.

On Fri, Oct 17, 2014 at 10:45 PM, Paul notifications@github.com wrote:

I believe this will be superseded when we merge #1768
#1768. Could you check if
your problem persists in that code, if not then we can close this, if it
does, could you suggest a modification against that commit?

Thanks,


Reply to this email directly or view it on GitHub
#1852 (comment).

@PaulL1
Copy link
Contributor

PaulL1 commented Oct 25, 2014

@baabgai : do you have some idea of what we would change to resolve that? Happy to merge a PR on it, I'm just not clear whether this particular PR will still merge.

@c0bra
Copy link
Member

c0bra commented Dec 2, 2014

Over two weeks without response. Closing for now but will re-open if there is an update.

@c0bra c0bra closed this Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.