Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upng-input hold $viewValue instead of $modelValue #1858
Merged
Conversation
…cause the viewValue is set when user press ESC
c0bra
added a commit
that referenced
this pull request
Dec 8, 2014
ng-input hold $viewValue instead of $modelValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
viniciusffj commentedOct 17, 2014
I had some trouble using ng-input for resetting to old value when user press ESC.
I found out that ng-input was storing the initial $modelValue and calling $setViewValue with it when user pressed ESC. This was causing trouble with my input validation, since my view value is different from my model value.
So I changed the ng-input to store the $viewValue instead of $modelValue.
Hope it helps.