Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadded an 'aggregationLabel' attribute on colDef #2237
Merged
Conversation
|
There are a lot of unnecessary whitespace changes in your first commit. Can you please fix those, squash these commits, and force push them to update this PR? Thanks! |
…e the i18n translation fixed test fixed whitespaces added an 'aggregationLabel' attribute on colDef to be able to override the i18n translation fixed test fixed whitespaces
|
ok. I have fixed the whitespace issue, squashed the commits and force pushed them. |
|
Excellent. Let me restart the travis job and we'll see how it goes. |
c0bra
added a commit
that referenced
this pull request
Dec 8, 2014
added an 'aggregationLabel' attribute on colDef
|
The re-ran Travis job passed but the output still said it failed, which is weird. I ran the tests locally and they passed so it looks good to me; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pedroclayman commentedNov 26, 2014
added an 'aggregationLabel' attribute on colDef to be able to override the i18n translation