Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfixes for #2346 #2303 #2351
Merged
fixes for #2346 #2303 #2351
Conversation
This was referenced Dec 15, 2014
|
Hey @c0bra . I commented this line s it was breaking move column functionality. Mouse click event for header cell was not reaching the move column handler. This line was added by you few days back. |
|
I think after some additional pushes my comment was removed because the line(s) changed. Sorry for any mistake/confusion/breakage on my part! I'm restarting the Travis job and it should run here shortly. |
jpuri
force-pushed the
jpuri:master
branch
4 times, most recently
from
093751a
to
c092b7c
|
Just did some changes in PR to fix test cases that were breaking. |
|
Thanks again @jpuri for all your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jpuri commentedDec 15, 2014
The PR will fix the following 2 major issue in move column functionality:
@c0bra I have commented line no. 148 in ui-grid-header-cell.js, please review.