Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upregression fix for: #2357 scrolling with large amount of columns,columns disappear after sort #2379
Conversation
disappear after sort scrollTop can now be undefined/null then that value should not be used for calculating if this is a scroll that doesn't have to update anything.
|
Looks good, thanks @jcompagner |
PaulL1
added a commit
that referenced
this pull request
Dec 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jcompagner commentedDec 17, 2014
scrollTop can now be undefined/null then that value should not be used
for calculating if this is a scroll that doesn't have to update
anything.