Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2149 - override expandableRowHeaderColDef.displayName #2381

Merged
merged 1 commit into from Dec 17, 2014

Conversation

@MattAtBT
Copy link
Contributor

MattAtBT commented Dec 17, 2014

The column generated when enabling expandable rows uses the header "Expandable Buttons". Until a method to configure this header text is provided, an empty string is preferable to the current text.

@c0bra c0bra added the unknown label Dec 17, 2014
@PaulL1
Copy link
Contributor

PaulL1 commented Dec 17, 2014

I was thinking instead of using i18n to configure this, but I see that your suggested change is the way things are done in selection, so merging this. I'm struggling to see a reason for a title, or a time that a title would be visible.

PaulL1 added a commit that referenced this pull request Dec 17, 2014
Issue #2149 - override expandableRowHeaderColDef.displayName
@PaulL1 PaulL1 merged commit 8d541b1 into angular-ui:master Dec 17, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@c0bra c0bra removed the unknown label Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.