Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up2.x - Expandable rows and actions column #2390
Conversation
|
Could you squash all these commits? Having 13 separate commits makes it really difficult to review and it's probably not going to get merged. Thanks |
|
Will do, I'll take a look at it this afternoon. Thanks. |
|
@c0bra I think I did that right? Sorry, I'm not great with git. |
…font style.
moberemk
commented
Jan 19, 2015
|
This hasn't been touched in a while, but it's functionality which my project could definitely use--any chance this will get merged in soon @c0bra? |
|
@moberemk Have you taken a look at what I did on https://github.com/gwin003/ng-grid? My main concern is what I did was too specific for my issue. |
|
Your second commit says what the PR is not what it adds/removes.
This was taken from here: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message |
faris-git
commented
Aug 18, 2016
|
I'm new to ui-grid. I'm looking for a feature expandable columns with combination of infinite scroll. Is this issue related to new feature which support expanding columns(having sub columns)? |
|
@gwin003 I am closing this PR due to inactivity. I realized this was partially our fault since there weren't a lot of active developers for a bit, but since you weren't able to address @JLLeitschuh's concerns. @faris-git If you would like this feature feel free to open a new PR for it at your leisure. @gwin003 is also free to do the same if he wishes. |
gwin003 commentedDec 18, 2014
Added ability to expand rows using an actions column in the grid
Actions column contains an edit, delete and expand button
Each of the buttons can be hidden or disabled
Able to supply callbacks for the edit and delete buttons so you can handle functionality in your application
HTML template that shows in the expandable div can be defined inside your ng-grid directive, and has access to the row entity
Note: The action column icons uses FontAwesome, so that will be required to use the buttons, unless the template is overridden.