Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upuser-configurable expandableRowHeaderColDef #2396
Conversation
|
I'm OK with this in concept, but two requests:
@jpuri, I'd also be interested in any comment you may have on this. |
| }, | ||
| userInjectedExpandableRowHeaderColDef = $scope.gridOptions.expandableRowHeaderColDef || {}, | ||
| finalExpandableRowHeaderColDef = angular.extend({}, defaultExpandableRowHeaderColDef, userInjectedExpandableRowHeaderColDef); | ||
| uiGridCtrl.grid.addRowHeaderColumn(finalExpandableRowHeaderColDef); |
This comment has been minimized.
This comment has been minimized.
jpuri
Dec 20, 2014
Contributor
Please use var declaration for variables you are declaring. I could not find one for userInjectedExpandableRowHeaderColDef and finalExpandableRowHeaderColDef. Also code styling in the if block needs to be corrected.
|
@PaulL1, Pull Request is ready for review again |
|
@jadelane if you're able, it would be really good to rebase these commits into one single commit. I would do it on my end but you'd be lost as the author and I wouldn't want you lose your "contributorship" :) |
|
@c0bra You could allow them to keep authorship: http://stackoverflow.com/a/3308780/3708426 |
JayHuang
commented
Oct 22, 2015
|
This PR seems to cause the Expand All button/icon to disappear and show "Expandable Buttons" in its place. |
jadelane commentedDec 18, 2014
Related to issue #1990.
This allows the user to configure the expandableRowHeaderColDef by adding a $scope.gridOptions.expandableRowHeaderColDef to js files.