Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate ui-grid-column-resizer.js #2416
Conversation
|
Have you tested this on several different browsers? If so, does it function the same way? I'm always hesitant to hard-code pixel values in calculations because invariably there's some browser or browser+OS combo that does things differently and will cause things to break in unexpected ways. |
It was tested in chrome, FF and IE (latest versions) 17 px is the minimum to work with all the three browsers (IE is the problem, chrome and FF are looking good with extra 2 px) There is no problem if the header is the longest value (so only if it's not an header cell i want to add 17 px). I don't have a solution for you If you don't want to write hard coded px.
This comment has been minimized.
This comment has been minimized.
OrenHasbani
commented on src/features/resize-columns/js/ui-grid-column-resizer.js in ba79a55
Dec 22, 2014
|
checks if it is header cell (without menu-button) |
This comment has been minimized.
This comment has been minimized.
OrenHasbani
commented on src/features/resize-columns/js/ui-grid-column-resizer.js in ba79a55
Dec 22, 2014
|
The minimum width that fits to all 3 browsers |
This comment has been minimized.
This comment has been minimized.
OrenHasbani
commented on src/features/resize-columns/js/ui-grid-column-resizer.js in ba79a55
Dec 22, 2014
|
It is not needed any more cause the calculation is done before. |
|
It was tested in chrome, FF and IE 11 (latest versions) I don't have a solution for you If you don't want to write hard coded px. |
|
The issue in question appears to have been marked close already. Closing this PR. |
OrenHasbani commentedDec 22, 2014
Double click won't cut the longest value in the column.
fix issue #1965:
#1965