Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(package): point 'main' to a valid filename #1503
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
nateabele
commented on ac90335
Nov 1, 2014
|
Um, it's been like that over the span of two releases, going back to February, and plenty of people installed it over NPM, so I can't help but think that it's correct the way it is. |
This comment has been minimized.
This comment has been minimized.
|
The current value of "main" doesn't prevent this package from being installed by NPM, but it is not consistent with what (most) other packages are doing. Take a look at the |
nateabele
added a commit
that referenced
this pull request
Nov 2, 2014
fix(package): point 'main' to a valid filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lucidenis commentedNov 1, 2014
This is a fix for #1502