Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(ui-sref): fixes not working with ng-click (angular-touch) if used without jQuery #827 #1580
Conversation
|
Wow. This looks like a whole lot of code for something that a library like UI Router should have no knowledge of. |
|
See follow-up comments on #827. |
|
I agree, fundamentally its an ng-touch issue. I could/should perhaps have titled the PR differently - something like feature(ui-sref): implement fastclick style behaviour (ie. remove 300ms delay on mobile) Would you consider that? |
|
From the looks of the code, it seems like something that could easily live on its own as an independent module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
homerjam commentedNov 25, 2014
No description provided.