From f5888fb7c348819b36cead8cb3f2db2a7e58a550 Mon Sep 17 00:00:00 2001 From: Chad Auld Date: Tue, 31 May 2016 17:13:18 -0600 Subject: [PATCH] feat(limit): Change multi-select limit attr (#1632) attr.limit should be an observable property so that it is updatable after initialization --- src/uiSelectDirective.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/uiSelectDirective.js b/src/uiSelectDirective.js index 14dfe713d..c6b5de4ea 100644 --- a/src/uiSelectDirective.js +++ b/src/uiSelectDirective.js @@ -60,9 +60,6 @@ uis.directive('uiSelect', $select.onSelectCallback = $parse(attrs.onSelect); $select.onRemoveCallback = $parse(attrs.onRemove); - //Limit the number of selections allowed - $select.limit = (angular.isDefined(attrs.limit)) ? parseInt(attrs.limit, 10) : undefined; - //Set reference to ngModel from uiSelectCtrl $select.ngModel = ngModel; @@ -86,6 +83,11 @@ uis.directive('uiSelect', var sortable = scope.$eval(attrs.sortable); $select.sortable = sortable !== undefined ? sortable : uiSelectConfig.sortable; }); + + attrs.$observe('limit', function() { + //Limit the number of selections allowed + $select.limit = (angular.isDefined(attrs.limit)) ? parseInt(attrs.limit, 10) : undefined; + }); scope.$watch('removeSelected', function() { var removeSelected = scope.$eval(attrs.removeSelected);