This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(highlight): ng-bind-html-unsafe is not available in 1.2+ #277
Conversation
Changed demo html from ng-bind-html-unsafe to ng-bind-html, Filter now returns trusted html using $sce provided by angular
ProLoser
added a commit
that referenced
this pull request
Sep 20, 2014
fix(highlight): ng-bind-html-unsafe is not available in 1.2+
d74deb5
into
angular-ui:angular1.2.x
1 check failed
1 check failed
F1LT3R
commented
Dec 17, 2014
|
The documentation on gh-pages still reflects ng-bind-html-unsafe. |
|
It's been renamed, I forgot the new name. Something like ng-bind-html
|
F1LT3R
commented
Dec 17, 2014
|
Yeah that's it. |
F1LT3R
commented
Dec 18, 2014
|
When I...
And I'm asked...
Which should I be choosing? "3" ? |
F1LT3R
commented
Dec 18, 2014
|
Hmmm, that's weird, I don't get that choice when I check out fresh and install npm/bower. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sirajc commentedAug 9, 2014
Issue
ng-bind-html-unsafeis not available in 1.2+ so we have to useng-bind-html, but these need trusted dataChanges
ng-bind-html-unsafetong-bind-html$sceprovided by angularsce.getTrusted(sce.HTML, trustedHtml), before comparing with test phrase