Skip to content
This repository has been archived by the owner. It is now read-only.

fix(highlight): ng-bind-html-unsafe is not available in 1.2+ #277

Merged
merged 1 commit into from Sep 20, 2014

Conversation

@sirajc
Copy link

sirajc commented Aug 9, 2014

Issue

ng-bind-html-unsafe is not available in 1.2+ so we have to use ng-bind-html, but these need trusted data

Changes

  1. Changed demo html to use ng-bind-html-unsafe to ng-bind-html
  2. Filter now returns trusted html using $sce provided by angular
  3. Updated test cases to convert the filtered value to html using sce.getTrusted(sce.HTML, trustedHtml) , before comparing with test phrase
Changed demo html from ng-bind-html-unsafe to ng-bind-html, Filter now returns trusted html using $sce provided by angular
ProLoser added a commit that referenced this pull request Sep 20, 2014
fix(highlight): ng-bind-html-unsafe is not available in 1.2+
@ProLoser ProLoser merged commit d74deb5 into angular-ui:angular1.2.x Sep 20, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@F1LT3R
Copy link

F1LT3R commented Dec 17, 2014

The documentation on gh-pages still reflects ng-bind-html-unsafe.

@ProLoser
Copy link
Member

ProLoser commented Dec 17, 2014

It's been renamed, I forgot the new name. Something like ng-bind-html
On Dec 17, 2014 1:15 PM, "Alistair G MacDonald" notifications@github.com
wrote:

The documentation on gh-pages still reflects ng-bind-html-unsafe.


Reply to this email directly or view it on GitHub
#277 (comment).

@F1LT3R
Copy link

F1LT3R commented Dec 17, 2014

Yeah that's it.

@ProLoser
Copy link
Member

ProLoser commented Dec 17, 2014

@F1LT3R sorry we're sort of tied up with our own projects, want to help us out and submit a pull request? maybe @realtica can take a look at it?

@F1LT3R
Copy link

F1LT3R commented Dec 18, 2014

When I...

npm install && bower install

And I'm asked...

Unable to find a suitable version for angular, please choose one:
    1) angular#1.0.8 which resolved to 1.0.8 and is required by angular-mocks#1.0.8
    2) angular#1.3.7 which resolved to 1.3.7 and is required by angular-mocks#1.3.7
    3) angular#>= 1.0.2 which resolved to 1.3.7 and is required by angular-ui-utilsPrefix the choice with ! to persist it to bower.json

Which should I be choosing? "3" ?

@F1LT3R
Copy link

F1LT3R commented Dec 18, 2014

Hmmm, that's weird, I don't get that choice when I check out fresh and install npm/bower.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.