From 5048f6e82e299b0733f34cbdcb1e7b1ef9a63210 Mon Sep 17 00:00:00 2001 From: Sergey Gultyayev Date: Fri, 7 Jul 2023 23:03:02 +0200 Subject: [PATCH] fix(@angular-devkit/build-angular): Set chunk names explicitly Explicitly set chunk name pattern to exclude them from Jest run --- .../src/tools/esbuild/application-code-bundle.ts | 1 + tests/legacy-cli/e2e/tests/basic/rebuild.ts | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts b/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts index 24a26761548f..0d118469a595 100644 --- a/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts +++ b/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts @@ -251,6 +251,7 @@ function getEsBuildCommonOptions(options: NormalizedApplicationBuildOptions): Bu outExtension: outExtension ? { '.js': `.${outExtension}` } : undefined, sourcemap: sourcemapOptions.scripts && (sourcemapOptions.hidden ? 'external' : true), splitting: true, + chunkNames: 'chunk-[hash]', tsconfig, external: externalDependencies, write: false, diff --git a/tests/legacy-cli/e2e/tests/basic/rebuild.ts b/tests/legacy-cli/e2e/tests/basic/rebuild.ts index e36c4020d631..1120ad0d8435 100644 --- a/tests/legacy-cli/e2e/tests/basic/rebuild.ts +++ b/tests/legacy-cli/e2e/tests/basic/rebuild.ts @@ -1,13 +1,13 @@ -import { waitForAnyProcessOutputToMatch, silentNg } from '../../utils/process'; -import { writeFile, writeMultipleFiles } from '../../utils/fs'; import fetch from 'node-fetch'; -import { ngServe } from '../../utils/project'; import { getGlobalVariable } from '../../utils/env'; +import { writeFile, writeMultipleFiles } from '../../utils/fs'; +import { silentNg, waitForAnyProcessOutputToMatch } from '../../utils/process'; +import { ngServe } from '../../utils/project'; export default async function () { const esbuild = getGlobalVariable('argv')['esbuild']; const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./; - const lazyBundleRegEx = esbuild ? /lazy\.module/ : /lazy_module_ts\.js/; + const lazyBundleRegEx = esbuild ? /chunk-/ : /lazy_module_ts\.js/; const port = await ngServe(); // Add a lazy module. @@ -17,6 +17,7 @@ export default async function () { // We need to use Promise.all to ensure we are waiting for the rebuild just before we write // the file, otherwise rebuilds can be too fast and fail CI. // Count the bundles. + // Verify that a new chunk was created. await Promise.all([ waitForAnyProcessOutputToMatch(lazyBundleRegEx), writeFile(