From 51d17d4d7059692ec3a5a506ba9245d070237226 Mon Sep 17 00:00:00 2001 From: Doug Parker Date: Thu, 17 Nov 2022 12:38:05 -0800 Subject: [PATCH] ci: fix update test to work when `@angular/cli` and `@angular/core` majors diverge During releases, there is a brief time where `@angular/core` has released the next version, but `@angular/cli` has not. This test currently fails in such a situation because `@angular/cli` wasn't new enough to trigger the multiple versions upgrade. This fix upgrades `@angular/core` instead, so it will always be consistent. --- .../e2e/tests/update/update-multiple-versions.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/legacy-cli/e2e/tests/update/update-multiple-versions.ts b/tests/legacy-cli/e2e/tests/update/update-multiple-versions.ts index a01bb2f1a34b..3f11413fd39c 100644 --- a/tests/legacy-cli/e2e/tests/update/update-multiple-versions.ts +++ b/tests/legacy-cli/e2e/tests/update/update-multiple-versions.ts @@ -15,9 +15,8 @@ export default async function () { extraArgs.push('--next'); } - // Update Angular from v12 to 13 - // TODO(dgp1130): Remove hard-coded `--next` after v15 release. - const { stdout } = await ng('update', '--next', ...extraArgs); + // Update Angular from v13 to 14 + const { stdout } = await ng('update', ...extraArgs); if (!/@angular\/core\s+13\.\d\.\d+ -> 14\.\d\.\d+\s+ng update @angular\/core@14/.test(stdout)) { // @angular/core 13.x.x -> 14.x.x ng update @angular/core@14 throw new Error( @@ -26,14 +25,14 @@ export default async function () { ); } - const { message } = await expectToFail(() => ng('update', '@angular/cli', ...extraArgs)); + const { message } = await expectToFail(() => ng('update', '@angular/core', ...extraArgs)); if ( !message.includes( - `Updating multiple major versions of '@angular/cli' at once is not supported`, + `Updating multiple major versions of '@angular/core' at once is not supported`, ) ) { throw new Error( - `Expected error message to include "Updating multiple major versions of '@angular/cli' at once is not supported" but didn't. OUTPUT: \n` + + `Expected error message to include "Updating multiple major versions of '@angular/core' at once is not supported" but didn't. OUTPUT: \n` + message, ); }