From c272172c84bef35f63038f1fc5fa184b1e2d99bf Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Tue, 25 Apr 2023 13:55:20 +0000 Subject: [PATCH] fix(@angular-devkit/build-angular): update esbuild builder complete log The complete log has been updated to match the RegExp in https://github.com/angular/angular-cli/blob/c045c99667cec8a5986302d59eef3d326e3a53d2/packages/schematics/angular/workspace/files/__dot__vscode/tasks.json.template#L18 as otherwise vscode debugged will not work correctly when using vscode launcher to launch the dev-server. (cherry picked from commit b2a4f3569bee44291f7bbc8fe957350e73bb58d8) --- .../build_angular/src/builders/browser-esbuild/index.ts | 2 +- tests/legacy-cli/e2e/tests/basic/rebuild.ts | 2 +- tests/legacy-cli/e2e/utils/project.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts b/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts index e3c56f69bbbf..6b2fc2b3a46e 100644 --- a/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts +++ b/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts @@ -267,7 +267,7 @@ async function execute( logBuildStats(context, metafile, initialFiles); const buildTime = Number(process.hrtime.bigint() - startTime) / 10 ** 9; - context.logger.info(`Complete. [${buildTime.toFixed(3)} seconds]`); + context.logger.info(`Application bundle generation complete. [${buildTime.toFixed(3)} seconds]`); return executionResult; } diff --git a/tests/legacy-cli/e2e/tests/basic/rebuild.ts b/tests/legacy-cli/e2e/tests/basic/rebuild.ts index 55d0bf339601..61fcba286105 100644 --- a/tests/legacy-cli/e2e/tests/basic/rebuild.ts +++ b/tests/legacy-cli/e2e/tests/basic/rebuild.ts @@ -6,7 +6,7 @@ import { getGlobalVariable } from '../../utils/env'; export default async function () { const esbuild = getGlobalVariable('argv')['esbuild']; - const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./; + const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./; const lazyBundleRegEx = esbuild ? /lazy\.module/ : /lazy_module_ts\.js/; const port = await ngServe(); diff --git a/tests/legacy-cli/e2e/utils/project.ts b/tests/legacy-cli/e2e/utils/project.ts index 5c3a937216ce..c22113c373ea 100644 --- a/tests/legacy-cli/e2e/utils/project.ts +++ b/tests/legacy-cli/e2e/utils/project.ts @@ -27,7 +27,7 @@ export async function ngServe(...args: string[]) { const port = await findFreePort(); const esbuild = getGlobalVariable('argv')['esbuild']; - const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./; + const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./; await execAndWaitForOutputToMatch( 'ng',