New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schematics for generating a component with onpush change detection strategy should not generate extra comma #13114

Closed
MurhafSousli opened this Issue Dec 3, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@MurhafSousli

MurhafSousli commented Dec 3, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI v7.1.0

Repro steps

Generate component and use the OnPush change detection strategy

image

e.g.:

ng generate @angular/material:nav sidenav --project=new-app --changeDetection=OnPush

Extra comma is generated

image

The log given by the failure

Desired functionality

Mention any other details that might be useful

@klemenoslaj

This comment has been minimized.

klemenoslaj commented Dec 3, 2018

I am pretty sure this is the issue with Angular Material schematics. In fact some minutes ago I opened the same issue on the material repo: angular/material2#14366

@devversion devversion closed this Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment