Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngsw-config.json has no schema, so no validation and no assistance #13324

Closed
cyrilletuzi opened this Issue Dec 28, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@cyrilletuzi
Copy link
Contributor

commented Dec 28, 2018

Feature Request

- [x] feature request

Commands

- [x] generate service-worker
- [x] add @angular/pwa

Versions

All CLI versions.

Repro steps

ng g service-worker
or
ng add @angular/pwa

The log given by the failure

There is no JSON schema for the ngsw-config.json, so no validation and no assistance.

This is especially inconvenient as a wrong config will often build with no errors, but then the service worker won't work.

Desired functionality

Validation and assistance for ngsw-config.json.

Mention any other details that might be useful

PR done in #13325

@gkalpak

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

@cyrilletuzi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

For people interested, it is available as an external contribution in @ngx-pwa/ngsw-schema lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.